DEV-14916 #16
Merged
DEV-14916 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souza-dan
reviewed
Jun 30, 2021
Comment on lines
5
to
+9
| identifier_prefix = "example-rds-pg-" | ||
| postgres_name = "example0" | ||
| parameter_group_name = "example-rds-postgres-pg" | ||
| username = "example-tamr-master" | ||
| password = "foo" #tfsec:ignore:GEN003 | ||
| username = "exampleUsername" | ||
| password = "examplePassword" #tfsec:ignore:GEN003 |
There was a problem hiding this comment.
Now that you have a var.name-prefix you could probably include it in some of these fields in place of example
There was a problem hiding this comment.
True but the limitation with username is that is does not accept any '-'s so while setting the name-prefix, we need to be mindful of that otherwise the apply would fail. Else we would need to massage the string to remove any special characters.
souza-dan
reviewed
Jul 1, 2021
variables.tf
Outdated
|
|
||
| variable "ingress_sg_ids" { | ||
| variable "security_group_ids" { | ||
| description = "List of security group IDs to allow ingress from (i.e. Spark cluster SG IDs, Tamr VM SG ID)" |
There was a problem hiding this comment.
Let's update this description. Can borrow from the terraform docs:
https://registry.terraform.io/modules/terraform-aws-modules/rds/aws/latest#input_vpc_security_group_ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.